fix: turns out prewhere and where filtering for the same property is no bueno #19472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Dec 21, 2023
Comment on lines
+281
to
287
| -- make sure we don't get the occasional unexpected future event | ||
| AND e.timestamp <= now() | ||
| -- and then any time filter for the events query | ||
| {events_timestamp_clause} | ||
| WHERE | ||
| notEmpty(`$session_id`) | ||
| {events_timestamp_clause} | ||
| {event_filter_where_conditions} |
There was a problem hiding this comment.
shifted the timestamp clause up into the prewhere here
pauldambra
commented
Dec 21, 2023
Comment on lines
88
to
93
| -- regardless of what other filters are applied | ||
| -- limit by storage TTL | ||
| AND e.timestamp >= %(clamped_to_storage_ttl)s | ||
| -- make sure we don't get the occasional unexpected future event | ||
| AND e.timestamp <= now() | ||
| -- and then any time filter for the events query |
There was a problem hiding this comment.
copied the comments up here to make the duplication more obvious so it'll annoy me and I can extract it next time I'm changing this file
fuziontech
pushed a commit
that referenced
this pull request
Jan 4, 2024
…no bueno (#19472) * fix: turns out prewhere and where filtering for the same property is no bueno * only not like an idiot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so, moves all of the timestamp filtering into the prewhere for the session events query (interestingly the log_entries query already did this)
@fuziontech figured this out during an incident