Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-analytics): Add deep scroll rate #19470

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat(web-analytics): Add deep scroll rate #19470

merged 1 commit into from
Dec 21, 2023

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Dec 21, 2023 •
edited
Loading

Problem

Continue #19458

Changes

  • Add % of users who scrolled enough to see 80% of the content on a page, or "deep scroll rate"
  • Hide scroll depth for users who've never sent us the relevant properties

How did you test this code?

Just manually, but it'll only be enabled on posthog for now

@robbie-c robbie-c changed the title Add deep scroll rate feat(web-analytics): Add deep scroll rate Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

mariusandra
mariusandra approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

@robbie-c robbie-c merged commit d1a4d66 into master Dec 21, 2023
81 of 83 checks passed
@robbie-c robbie-c deleted the add-deep-scroll-rate branch December 21, 2023 08:46
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
@robbie-c @fuziontech
feat(web-analytics): Add deep scroll rate (#19470)
2471c9d 
Add deep scroll rate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

@benjackwhite benjackwhite Awaiting requested review from benjackwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbie-c @mariusandra