Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed a few days ago (and then forgot 😬 ) that we are getting a ton of errors for missing
rows_synced
key. https://posthog.sentry.io/issues/4640389037/?project=1899813&query=is:unresolved+!url:http://billing.dev.posthog.dev+usage&statsPeriod=14d&stream_index=0Then today Cameron found this, which led me down a rabbit hole to realize that orgs aren't getting properly quota limited. Someone's billing limit will be set, but they are still accruing usage (and not being charged for it, thankfully).
I'm wondering if this is the culprit. I don't really know if my fix here is the right solution... does the key not exist in the usage record because it doesn't exist in billing?
Changes
.get()
s the key instead of assuming it's there.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?