Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added last_name field #19463

Merged
merged 15 commits into from
Dec 21, 2023
Merged

feat: Added last_name field #19463

merged 15 commits into from
Dec 21, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 20, 2023

Problem

Changes

  • Returns the last_name property - useful for anywhere that we want to make it clearer about the person (such as Members areas)
  • Updates the "ProfilePicture" component to take simply a user object which then takes care of generating the right name with email etc.
Screenshot 2023-12-21 at 10 06 15

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite changed the title feat: Added name field feat: Added last_name field Dec 21, 2023
Copy link
Contributor

github-actions bot commented Dec 21, 2023

Size Change: +2.06 kB (0%)

Total Size: 2 MB

Filename Size Change
frontend/dist/toolbar.js 2 MB +2.06 kB (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite requested a review from a team December 21, 2023 10:04
@benjackwhite benjackwhite marked this pull request as ready for review December 21, 2023 10:05
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite merged commit ce48493 into master Dec 21, 2023
78 checks passed
@benjackwhite benjackwhite deleted the feat/user-full-name branch December 21, 2023 15:39
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants