Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a/b testing): posthog-3000 fixes #19447

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix(a/b testing): posthog-3000 fixes #19447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01819c8
fix 3000 issues
jurajmajerik Dec 20, 2023
143bb38
Update UI snapshots for `chromium` (2)
github-actions[bot] Dec 20, 2023
df6b46d
Merge branch 'master' into ab-testing/fix-3000
jurajmajerik Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/__snapshots__/scenes-app-experiments--complete-funnel-experiment.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-experiments--running-trend-experiment.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions frontend/src/lib/components/Support/supportLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ export const TARGET_AREA_TO_NAME = {
data_management: 'Data Management',
data_warehouse: 'Data Warehouse',
ingestion: 'Event Ingestion',
experiments: 'Experiments',
experiments: 'A/B Testing',
feature_flags: 'Feature Flags',
analytics: 'Product Analytics (Insights, Dashboards, Annotations)',
session_replay: 'Session Replay (Recordings)',
toolbar: 'Toolbar & heatmaps',
toolbar: 'Toolbar & Heatmaps',
surveys: 'Surveys',
web_analytics: 'Web Analytics',
'posthog-3000': 'PostHog 3000',
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/scenes/experiments/Experiment.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@

.exp-description {
font-style: italic;
color: var(--muted);
}

.participants {
Expand Down Expand Up @@ -209,3 +208,10 @@
border: 1px solid var(--border);
border-radius: var(--radius);
}

.exp-flag-copy-label {
font-size: 11px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.5px;
}
18 changes: 16 additions & 2 deletions frontend/src/scenes/experiments/Experiment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,21 @@ export function Experiment(): JSX.Element {
}
/>
<div className="w-full pb-4">
<span className="exp-description">
<div>
{experiment.feature_flag && (
<>
<div className="exp-flag-copy-label">Feature flag</div>
<CopyToClipboardInline
iconStyle={{ color: 'var(--lemon-button-icon-opacity)' }}
className="font-normal text-sm"
description="feature flag key"
>
{experiment.feature_flag.key}
</CopyToClipboardInline>
</>
)}
</div>
<div className="mt-4 exp-description">
{isExperimentRunning ? (
<EditableField
multiline
Expand All @@ -641,7 +655,7 @@ export function Experiment(): JSX.Element {
) : (
<>{experiment.description || 'There is no description for this experiment.'}</>
)}
</span>
</div>
</div>
</div>
<div className="mb-4">
Expand Down
Loading