Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change default theme to light #19444

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

benjackwhite
Copy link
Contributor

Problem

We want to keep the light theme by default so it is more of a conscious choice to use dark mode whilst we keep working on it.

Changes

  • Adds "system" as a persisted choice (otherwise we would just revert to light mode always)
  • Changes the default to "light"

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Reset the DB, tried each option out - all looks good

@benjackwhite benjackwhite requested review from corywatilo and a team December 20, 2023 13:01
Copy link
Contributor

Size Change: -1.14 kB (0%)

Total Size: 2 MB

Filename Size Change
frontend/dist/toolbar.js 2 MB -1.14 kB (0%)

compressed-size-action

Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we can but is it worth backfilling all users to light mode?

@benjackwhite
Copy link
Contributor Author

Not sure we can but is it worth backfilling all users to light mode?

They will be - if they selected a mode then that will be there mode - only if they didn't select a mode will we be defaulting them to light now

@benjackwhite benjackwhite merged commit 296554f into master Dec 20, 2023
79 checks passed
@benjackwhite benjackwhite deleted the fix/light-mode-default branch December 20, 2023 14:50
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants