chore(hogql): Rename PersonsQuery to ActorsQuery #19441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 2 MB ℹ️ View Unchanged
|
webjunkie
force-pushed
the
chore/persons-query-rename
branch
from
ef85ea8 to
4e1e988
Compare
mariusandra
approved these changes
Dec 21, 2023
| @@ -46,30 +46,30 @@ export const retentionModalLogic = kea<retentionModalLogicType>([ | |||
| return aggregationLabel(aggregation_group_type_index) | |||
| }, | |||
| ], | |||
| personsQuery: [ | |||
| ActorsQuery: [ | |||
There was a problem hiding this comment.
Should this be PascalCase? We usually camelCase variables and PascalCase types and classes 🤷
There was a problem hiding this comment.
Hmm, good catch.. I thought I did case sensitive search and replace 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PersonsQuery since #19211 does not only care about persons, but also groups.
Changes
How did you test this code?