Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation): alignment of settings icons #19437

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix(navigation): alignment of settings icons #19437

merged 3 commits into from
Dec 20, 2023

Conversation

thmsobrmlr
Copy link
Contributor

Problem

One other thing but probably beyond the scope of this PR - the settings icon next to the person feels like it should be right aligned so that it is inline with the one below it
-- @daibhin #19415 (review)

Changes

before
Screenshot 2023-12-20 at 11 56 45

after
Screenshot 2023-12-20 at 12 08 03

How did you test this code?

👀

@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) December 20, 2023 11:31
@thmsobrmlr thmsobrmlr merged commit fa62bcf into master Dec 20, 2023
78 checks passed
@thmsobrmlr thmsobrmlr deleted the site-popover-account-info branch December 20, 2023 11:35
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
@thmsobrmlr @fuziontech
fix(navigation): alignment of settings icons (#19437)
0948bc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @daibhin