Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issues with experiment dropdown #19436

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: Issues with experiment dropdown #19436

merged 3 commits into from
Dec 20, 2023

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 20, 2023 •
edited
Loading

Problem

The dropdown value was hardcoded (whoops...) and the dropdown width needed tweaking

Changes

  • Fixes both these issues
  • Follow up might try and modify the underlying component to be "min-width" instead of fixed width...

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

jurajmajerik
jurajmajerik approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@jurajmajerik jurajmajerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jurajmajerik jurajmajerik enabled auto-merge (squash) December 20, 2023 09:07
@jurajmajerik jurajmajerik merged commit 33227cb into master Dec 20, 2023
78 checks passed
@jurajmajerik jurajmajerik deleted the fix/experiments-dropdown branch December 20, 2023 09:38
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
@benjackwhite @fuziontech
fix: Issues with experiment dropdown (#19436)
0964bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajmajerik jurajmajerik jurajmajerik approved these changes

@liyiy liyiy Awaiting requested review from liyiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @jurajmajerik