Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make the command bar responsive #19411

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 19, 2023

Problem

Tried searching on my phone earlier and it was completely unusable.

Changes

Now it is somewhat usable....

  • Removed shadows that didn't work due to overflow hidden (to be fixed later)
  • Made it responsive (max and mins instead of fixed dimensions
  • Hide preview if the screen is too small
  • Made the Esc key command hit clickable
Before After
Screenshot 2023-12-19 at 16 12 13 Screenshot 2023-12-19 at 16 10 32
Screenshot 2023-12-19 at 16 12 00 Screenshot 2023-12-19 at 16 14 45

How did you test this code?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

  • chromium: 0 added, 5 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@benjackwhite benjackwhite changed the title Make the command bar responsive feat: Make the command bar responsive Dec 19, 2023
Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@benjackwhite benjackwhite requested a review from a team December 19, 2023 17:37
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Removed shadows that didn't work due to overflow hidden (to be fixed later)

Do you mean they don't look good or is there an issue? I can't seem to see a difference without overflow hidden or when using shadow in another place.

The other changes are great :)

@benjackwhite
Copy link
Contributor Author

  • Removed shadows that didn't work due to overflow hidden (to be fixed later)

Do you mean they don't look good or is there an issue? I can't seem to see a difference without overflow hidden or when using shadow in another place.

The other changes are great :)

Yeah I realised later it wasn't that the overflow hidden was the issue, but rather that the default shadow just doesn't work here 😅

@benjackwhite benjackwhite merged commit 63d73bc into master Dec 20, 2023
81 of 82 checks passed
@benjackwhite benjackwhite deleted the fix/command-box-css branch December 20, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants