feat: keyboard placeholder #19406
Merged
feat: keyboard placeholder #19406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Dec 19, 2023
Comment on lines
+121
to
+122
| x?: number | ||
| y?: number |
There was a problem hiding this comment.
description and reality didn't line up in the schema
pauldambra
commented
Dec 19, 2023
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
pauldambra
commented
Dec 19, 2023
| * @description width and height are the dimensions of the element, the only accepted units is pixels. You can omit the unit. | ||
| * @description the width dimension of the element, either '100vw' i.e. viewport width. Or a value in pixels. You can omit the unit when specifying pixels. | ||
| */ | ||
| width: number | '100vw' |
There was a problem hiding this comment.
since I was allowing this for the custom event I thought I'd allow it here too.
We may never send it but 🤷
pauldambra
commented
Dec 19, 2023
Comment on lines
+305
to
+316
| * @description x and y are the top left corner of the element, if they are present then the element is absolutely positioned, if they are not present then the keyboard is at the bottom of the screen | ||
| */ | ||
| x?: number | ||
| y?: number | ||
| /* | ||
| * @description the height dimension of the keyboard, the only accepted units is pixels. You can omit the unit. | ||
| */ | ||
| height: number | ||
| /* | ||
| * @description the width dimension of the keyboard, the only accepted units is pixels. You can omit the unit. If not present defaults to width of the viewport | ||
| */ | ||
| width?: number |
There was a problem hiding this comment.
setting x and y is possible but not expected
setting width is possible but not expected
4 tasks
marandaneto
reviewed
Dec 19, 2023
Comment on lines
+86
to
+96
| function isKeyboardEvent(x: unknown): x is keyboardEvent { | ||
| return ( | ||
| typeof x === 'object' && | ||
| x !== null && | ||
| 'data' in x && | ||
| typeof x.data === 'object' && | ||
| x.data !== null && | ||
| 'tag' in x.data && | ||
| x.data.tag === 'keyboard' | ||
| ) | ||
| } |
There was a problem hiding this comment.
What? it's my most elegant code 🙈 🤣
marandaneto
approved these changes
Dec 19, 2023
Yep, me too! It's an overlay but I'll be amazed if it doesn't need a second pass 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the keyboard opens or closes on the mobile app, we want to send a custom event, and see that happen so our users understand what their users see