Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Fix custom labels on bar chart #19393

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Dec 18, 2023

Problem

https://posthoghelp.zendesk.com/agent/tickets/7857

Changes

Change the order of prioritising which thing to show as the label

Single series, custom label
Screenshot 2023-12-18 at 14 14 43

Single series, action
Screenshot 2023-12-18 at 14 15 03

Single series, event
Screenshot 2023-12-18 at 14 15 28

Single series, breakdown, custom label (we don't hide the series name here)
Screenshot 2023-12-18 at 14 16 07

Single series, breakdown, action
Screenshot 2023-12-18 at 14 18 57

Single series, breakdown, event
Screenshot 2023-12-18 at 14 19 28

Combined series
Screenshot 2023-12-18 at 14 22 03

Combined series, breakdown
Screenshot 2023-12-18 at 14 20 14

How did you test this code?

@robbie-c robbie-c changed the title Fix custom name fix(insights): Fix custom labels on bar chart Dec 18, 2023
@robbie-c robbie-c marked this pull request as ready for review December 18, 2023 14:24
Copy link
Contributor

Size Change: 0 B

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.99 MB

compressed-size-action

@robbie-c robbie-c merged commit 35cd465 into master Dec 18, 2023
83 of 85 checks passed
@robbie-c robbie-c deleted the fix-custom-name branch December 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants