Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(3000): Remove organization from breadcrumbs #19365

Closed
wants to merge 4 commits into from

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Dec 15, 2023

Changes

I propose we introduce the following split in 3000: organization switching lives in the account popover, while project switching lives in breadcrumbs. Currently you can do the former from breadcrumbs AND the popover, while the latter ONLY from breadcrumbs. I'm not sure that this is entirely good for the discoverability of projects, but I definitely think that it's redundant for orgs.

To this end, this PR removes the organization breadcrumb in 3000.

@Twixes Twixes requested review from corywatilo and a team December 15, 2023 17:17
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

179 snapshot changes in total. 0 added, 179 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +51 B (0%)

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.99 MB +51 B (0%)

compressed-size-action

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the pre-3000 UI is also affected when the code suggests that it shouldn't be?

@thmsobrmlr
Copy link
Contributor

I initially thought this is a great idea - people likely don't switch the organization much and this simplifies the UI. Unexpectedly the org switcher seems to be used quite a bunch by users though https://app.posthog.com/data-management/actions/59306 (given I've not made a mistake setting up the action).

@Twixes
Copy link
Member Author

Twixes commented Dec 15, 2023

Hmm, that's interesting @thmsobrmlr! Yeah, it does look like the org switcher has a bit over 1/3 of the project switcher's DAUs in 3000 – which is a big chunk, because project switching is not even available elsewhere. Though also interesting, because I would suspect A LOT more users to be multi-project rather than multi-org.
New organizations are created from breadcrumbs more than from the account popover.
(Insight for both analyses.)
So let's say we keep the organization in breadcrumbs.

@Twixes Twixes closed this Dec 15, 2023
@corywatilo
Copy link
Contributor

I've actually been using the breadcrumb a ton to switch orgs! Ultimately I think it should move to the nav column (likely at the top) as this turned out to be a pretty good solution for a company that rhymes with Leap. But what we have works for now and definitely helps keep all the controls in one place and prevents thrash of what to expect where.

Now if only we can clear up the ambiguity between project settings, personal settings, and billing...

@daibhin daibhin deleted the skip-org-in-breadcrumbs branch December 18, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants