Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ScrollableShadows component #19356

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 15, 2023

Problem

Working on adding vertical scrollers on a different feature and decided it would make sense to make a proper component here

Changes

  • Adds the ScrollableShadows component
  • Replaces uses of the other "scrollable" stuff
  • Improves the useScrollable to not fire if there is no change
  • Adds it to the 3000 navbar
  • NOTE: Wanted to add it to the Panel tab list but couldn't figure out all the weirdness around the transforming stuff...

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested review from Twixes and a team December 15, 2023 13:56
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +16 B (0%)

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.99 MB +16 B (0%)

compressed-size-action

@benjackwhite benjackwhite merged commit 58be51a into master Dec 18, 2023
78 checks passed
@benjackwhite benjackwhite deleted the feat/scrollable-component branch December 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants