Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(3000): a bunch of minor fixes #19354

Merged
merged 6 commits into from
Dec 18, 2023
Merged

fix(3000): a bunch of minor fixes #19354

merged 6 commits into from
Dec 18, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 15, 2023 •
edited
Loading

Problem

A bunch of minor issues

Changes

This PR:

  • adds a white background to the sql insight loading state
  • fixes the sticky column background in notebooks / insight tables
  • fixes the delete button style in delete dashboard modal
  • uses matter font in site popover consistently

How did you test this code?

👀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.99 MB

compressed-size-action

@thmsobrmlr thmsobrmlr marked this pull request as ready for review December 15, 2023 17:46
@thmsobrmlr thmsobrmlr requested a review from a team December 18, 2023 08:44
@thmsobrmlr thmsobrmlr merged commit 0d70afb into master Dec 18, 2023
82 checks passed
@thmsobrmlr thmsobrmlr deleted the some-more-fixes branch December 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @daibhin