feat(hogql): always provide an alias when printing out clickhouse

[mariusandra]

Problem

This query failed with PoE off:

SELECT id, id, created_at, 1 FROM persons INNER JOIN (SELECT DISTINCT person_id FROM events WHERE equals(event, 'clicky-4')) AS source ON equals(persons.id, source.person_id) ORDER BY created_at DESC

with

Field person_id not found on query with alias source

Changes

The field is on a joined table in a subquery. Just accessing it with its id is not enough.

Let's fix this by making aliases explicit in ClickHouse. This avoids surprises.

How did you test this code?

Updated a lot of tests. Converted some older SQL comparison tests into snapshot tests.

[robbie-c]

Are there any edge cases around having two things alias to the same name?
E.g. select properties, person.properties from events

[webjunkie]

Code looks alright 👀

[mariusandra]

Are there any edge cases around having two things alias to the same name? E.g. select properties, person.properties from events

No. In this case only the second one would get the explicit alias.