-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Data pipelines unsubscribe modal #19334
Merged
Merged
Changes from 30 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
c619609
feat: Exports unsubscribe modal
tiina303 96d480f
Changes
Twixes 3281075
Fix query
Twixes 244fbcd
Make modal work for plugin configs
Twixes b0eb00c
plugins part should work now
tiina303 afc95de
wip batch exports
tiina303 300fa9f
batch exports finished + modal access listeners
tiina303 0929b8d
fix name and description to be writable
tiina303 7acd304
rename and move table to main billing unsub modal
raquelmsmith 06c7e85
add text and disabled reason
raquelmsmith a1967e9
improve disabled state
raquelmsmith 599b077
Update UI snapshots for `chromium` (1)
github-actions[bot] 6c7ccac
move into billing
raquelmsmith 102bbae
use correct product name
raquelmsmith 9609f09
stories
raquelmsmith 0354840
fix
raquelmsmith 001db20
make images smaller
raquelmsmith c92b09d
Update UI snapshots for `chromium` (1)
github-actions[bot] 48cec19
Update UI snapshots for `chromium` (1)
github-actions[bot] 8fedd05
Update frontend/src/scenes/plugins/plugin/PluginImage.tsx
raquelmsmith 9c9a01f
remove old logic
raquelmsmith 9d3e9b9
fix
raquelmsmith 19e8168
fix
raquelmsmith d840c04
fix overlap
raquelmsmith 74a07da
Update UI snapshots for `chromium` (1)
github-actions[bot] 86ad60e
delete snapshots so they are regenerated
raquelmsmith 1be1eb6
Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…
raquelmsmith 2879415
Update UI snapshots for `chromium` (1)
github-actions[bot] 0da4867
fix test
raquelmsmith 24fb092
Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…
raquelmsmith ec96787
unfix?
raquelmsmith b5821a3
project not team
raquelmsmith 070814b
reorder columns
raquelmsmith fb37011
Merge branch 'master' into exports-unsubscribe-modal
raquelmsmith 3ab1e56
Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…
raquelmsmith 75b6984
Update UI snapshots for `chromium` (1)
github-actions[bot] e0767df
Update UI snapshots for `chromium` (1)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+415 Bytes
(100%)
...tend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+330 Bytes
(100%)
...end/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.5 KB
...tend/__snapshots__/scenes-other-billing-v2--billing-unsubscribe-modal--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.8 KB
...end/__snapshots__/scenes-other-billing-v2--billing-unsubscribe-modal--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+52.2 KB
...s__/scenes-other-billing-v2--billing-unsubscribe-modal-data-pipelines--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+52.5 KB
...__/scenes-other-billing-v2--billing-unsubscribe-modal-data-pipelines--light.png
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Team" is our internal naming, UI should only ever say "Project". |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions
22
frontend/src/mocks/fixtures/api/organizations/@current/@current.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"id": "0178a3ab-d163-0000-4b55-bceadebb03fa", | ||
"name": "Hogflix Movies", | ||
"created_at": "2021-04-05T20:14:09.763753Z", | ||
"updated_at": "2021-04-05T20:14:25.443181Z", | ||
"membership_level": 15, | ||
"plugins_access_level": 9, | ||
"teams": [ | ||
{ | ||
"id": 2, | ||
"uuid": "0178a3ab-d1e5-0000-c5ca-da746c68f506", | ||
"organization": "0178a3ab-d163-0000-4b55-bceadebb03fa", | ||
"api_token": "tJy-b6mTLwvNP_ZJHrfgn99pQCYOGFE3-nwpb8utFa8", | ||
"name": "Hogflix Demo App", | ||
"completed_snippet_onboarding": true, | ||
"ingested_event": true, | ||
"is_demo": true, | ||
"timezone": "Europe/Kiev" | ||
} | ||
], | ||
"available_features": [] | ||
} |
34 changes: 34 additions & 0 deletions
34
frontend/src/mocks/fixtures/api/organizations/@current/batchExports.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{ | ||
"count": 1, | ||
"next": null, | ||
"previous": null, | ||
"results": [ | ||
{ | ||
"id": "018c8dcd-1598-0001-a082-fa2d1e2dbb74", | ||
"team_id": 2, | ||
"name": "my export", | ||
"destination": { | ||
"type": "Postgres", | ||
"config": { | ||
"host": "sdsdd.domc.com", | ||
"port": 5432, | ||
"user": "sdssd", | ||
"schema": "sddd", | ||
"database": "sdsd", | ||
"password": "sdsdsd", | ||
"table_name": "ssss", | ||
"exclude_events": ["sdd"], | ||
"include_events": ["sdddddd"] | ||
} | ||
}, | ||
"interval": "day", | ||
"paused": false, | ||
"created_at": "2023-12-21T19:14:37.135878Z", | ||
"last_updated_at": "2023-12-22T18:42:43.863292Z", | ||
"last_paused_at": "2023-12-22T18:41:50.122946Z", | ||
"start_at": null, | ||
"end_at": "2023-12-30T08:00:00Z", | ||
"latest_runs": [] | ||
} | ||
] | ||
} |
24 changes: 24 additions & 0 deletions
24
...tend/src/mocks/fixtures/api/organizations/@current/plugins/exportsUnsubscribeConfigs.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
[ | ||
{ | ||
"id": 2, | ||
"plugin": 4, | ||
"enabled": true, | ||
"order": 2, | ||
"config": { | ||
"host": "eu.posthog.com", | ||
"replication": "1", | ||
"disable_geoip": "No", | ||
"project_api_key": "sdsdd", | ||
"events_to_ignore": "" | ||
}, | ||
"error": null, | ||
"team_id": 2, | ||
"plugin_info": null, | ||
"delivery_rate_24h": null, | ||
"created_at": "2023-12-22T18:23:03.907137Z", | ||
"updated_at": "2023-12-22T18:42:54.074571Z", | ||
"name": "Replicator", | ||
"description": "Replicate PostHog event stream in another PostHog instance", | ||
"deleted": false | ||
} | ||
] |
219 changes: 219 additions & 0 deletions
219
frontend/src/mocks/fixtures/api/organizations/@current/plugins/plugins.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,219 @@ | ||
{ | ||
"count": 4, | ||
"next": null, | ||
"previous": null, | ||
"results": [ | ||
{ | ||
"id": 4, | ||
"plugin_type": "custom", | ||
"name": "Replicator", | ||
"description": "Replicate PostHog event stream in another PostHog instance", | ||
"url": "https://github.com/PostHog/posthog-plugin-replicator", | ||
"icon": null, | ||
"config_schema": [ | ||
{ | ||
"key": "host", | ||
"hint": "E.g. posthog.yourcompany.com", | ||
"name": "Host", | ||
"type": "string", | ||
"required": true | ||
}, | ||
{ | ||
"key": "project_api_key", | ||
"hint": "Grab it from e.g. https://posthog.yourcompany.com/project/settings", | ||
"name": "Project API Key", | ||
"type": "string", | ||
"required": true | ||
}, | ||
{ | ||
"key": "replication", | ||
"hint": "How many times should each event be sent", | ||
"name": "Replication", | ||
"type": "string", | ||
"default": "1", | ||
"required": false | ||
}, | ||
{ | ||
"key": "events_to_ignore", | ||
"hint": "Comma-separated list of events to ignore, e.g. $pageleave, purchase", | ||
"name": "Events to ignore", | ||
"type": "string", | ||
"default": "", | ||
"required": false | ||
}, | ||
{ | ||
"key": "disable_geoip", | ||
"hint": "Add $disable_geoip so that the receiving PostHog instance doesn't try to resolve the IP address.", | ||
"name": "Disable Geo IP?", | ||
"type": "choice", | ||
"choices": ["Yes", "No"], | ||
"default": "No", | ||
"required": false | ||
} | ||
], | ||
"tag": "cec29cd0dea20465839dd301894e4798d6dd6356", | ||
"latest_tag": "cec29cd0dea20465839dd301894e4798d6dd6356", | ||
"is_global": false, | ||
"organization_id": "018aaa96-00d3-0000-b845-8eb60884ff76", | ||
"organization_name": "test 123", | ||
"capabilities": {}, | ||
"metrics": {}, | ||
"public_jobs": {} | ||
}, | ||
{ | ||
"id": 3, | ||
"plugin_type": "custom", | ||
"name": "GeoIP", | ||
"description": "Enrich PostHog events and persons with IP location data", | ||
"url": "https://github.com/PostHog/posthog-plugin-geoip", | ||
"icon": null, | ||
"config_schema": [], | ||
"tag": "2dd67e1dec9c8b5febd7a6d9235c51072950cd37", | ||
"latest_tag": "2dd67e1dec9c8b5febd7a6d9235c51072950cd37", | ||
"is_global": false, | ||
"organization_id": "018aaa96-00d3-0000-b845-8eb60884ff76", | ||
"organization_name": "test 123", | ||
"capabilities": {}, | ||
"metrics": {}, | ||
"public_jobs": {} | ||
}, | ||
{ | ||
"id": 2, | ||
"plugin_type": "custom", | ||
"name": "Customer.io", | ||
"description": "Send event data and emails into Customer.io.", | ||
"url": "https://github.com/PostHog/customerio-plugin", | ||
"icon": null, | ||
"config_schema": [ | ||
{ | ||
"key": "customerioSiteId", | ||
"hint": "Provided during Customer.io setup.", | ||
"name": "Customer.io Site ID", | ||
"type": "string", | ||
"secret": true, | ||
"default": "", | ||
"required": true | ||
}, | ||
{ | ||
"key": "customerioToken", | ||
"hint": "Provided during Customer.io setup.", | ||
"name": "Customer.io API Key", | ||
"type": "string", | ||
"secret": true, | ||
"default": "", | ||
"required": true | ||
}, | ||
{ | ||
"key": "host", | ||
"hint": "Use the EU variant if your Customer.io account is based in the EU region.", | ||
"name": "Tracking Endpoint", | ||
"type": "choice", | ||
"choices": ["track.customer.io", "track-eu.customer.io"], | ||
"default": "track.customer.io" | ||
}, | ||
{ | ||
"key": "identifyByEmail", | ||
"hint": "If enabled, the plugin will identify users by email instead of ID, whenever an email is available.", | ||
"name": "Identify by email", | ||
"type": "choice", | ||
"choices": ["Yes", "No"], | ||
"default": "No" | ||
}, | ||
{ | ||
"key": "sendEventsFromAnonymousUsers", | ||
"hint": "Customer.io pricing is based on the number of customers. This is an option to only send events from users that have been identified. Take into consideration that merging after identification won't work (as those previously anonymous events won't be there).", | ||
"name": "Filtering of Anonymous Users", | ||
"type": "choice", | ||
"choices": [ | ||
"Send all events", | ||
"Only send events from users that have been identified", | ||
"Only send events from users with emails" | ||
], | ||
"default": "Send all events" | ||
}, | ||
{ | ||
"key": "eventsToSend", | ||
"hint": "If this is set, only the specified events (comma-separated) will be sent to Customer.io.", | ||
"name": "PostHog Event Allowlist", | ||
"type": "string" | ||
} | ||
], | ||
"tag": "0b86074d53aa11617290f12501b56cfc27c7abde", | ||
"latest_tag": "0b86074d53aa11617290f12501b56cfc27c7abde", | ||
"is_global": false, | ||
"organization_id": "018aaa96-00d3-0000-b845-8eb60884ff76", | ||
"organization_name": "test 123", | ||
"capabilities": {}, | ||
"metrics": {}, | ||
"public_jobs": {} | ||
}, | ||
{ | ||
"id": 1, | ||
"plugin_type": "custom", | ||
"name": "BigQuery Export", | ||
"description": "Sends events to a BigQuery database on ingestion.", | ||
"url": "https://github.com/PostHog/bigquery-plugin", | ||
"icon": null, | ||
"config_schema": [ | ||
{ | ||
"key": "googleCloudKeyJson", | ||
"name": "JSON file with your google cloud key", | ||
"type": "attachment", | ||
"secret": true, | ||
"required": true | ||
}, | ||
{ | ||
"key": "datasetId", | ||
"hint": "In case Google Cloud tells you \"my-project-123245:Something\", use \"Something\" as the ID.", | ||
"name": "Dataset ID", | ||
"type": "string", | ||
"required": true | ||
}, | ||
{ | ||
"key": "tableId", | ||
"hint": "A table will be created if it does not exist.", | ||
"name": "Table ID", | ||
"type": "string", | ||
"required": true | ||
}, | ||
{ | ||
"key": "exportEventsToIgnore", | ||
"hint": "Comma separated list of events to ignore", | ||
"name": "Events to ignore", | ||
"type": "string", | ||
"default": "$feature_flag_called,$autocapture" | ||
}, | ||
{ | ||
"key": "exportEventsBufferBytes", | ||
"hint": "Default 1MB. Upload events after buffering this many of them. The value must be between 1 MB and 10 MB.", | ||
"name": "Maximum upload size in bytes", | ||
"type": "string", | ||
"default": "1048576" | ||
}, | ||
{ | ||
"key": "exportEventsBufferSeconds", | ||
"hint": "Default 30 seconds. If there are events to upload and this many seconds has passed since the last upload, then upload the queued events. The value must be between 1 and 600 seconds.", | ||
"name": "Export events at least every X seconds", | ||
"type": "string", | ||
"default": "30" | ||
}, | ||
{ | ||
"key": "exportElementsOnAnyEvent", | ||
"hint": "Advanced", | ||
"name": "Export the property $elements on events that aren't called `$autocapture`?", | ||
"type": "choice", | ||
"choices": ["Yes", "No"], | ||
"default": "No" | ||
} | ||
], | ||
"tag": "5f5dcbc2f6a36ea7e9700ab36cc9397d92742ca3", | ||
"latest_tag": "5f5dcbc2f6a36ea7e9700ab36cc9397d92742ca3", | ||
"is_global": false, | ||
"organization_id": "018aaa96-00d3-0000-b845-8eb60884ff76", | ||
"organization_name": "test 123", | ||
"capabilities": {}, | ||
"metrics": {}, | ||
"public_jobs": {} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there's only a small layout shift here, but a few notes on this UI:
width: 0
so that it takes up as little space as possibleMight be good as a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this UI was touched as part of this PR? But not sure why this snapshot would have changed... either way I'll leave you two to update this in a separate PR.