feat(trends): Add "Decimal places" as a Trends viz option

[Twixes]

Problem

Solves ZEN-8274.

Changes

Added a new visualization option (frontend-only) to Trends called "Decimal places":

How did you test this code?

Updated some frontend tests. Let me know if there are any other tests I should add.

[github-actions]

Size Change: +153 kB (+8%) 🔍

Total Size: 1.99 MB

Filename	Size	Change
frontend/dist/toolbar.js	1.99 MB	+153 kB (+8%)	🔍

_{compressed-size-action}

[thmsobrmlr]

Super cool and works really well. There's a backend side filters_to_query method, where the filter needs to be added as well.

[thmsobrmlr]

To make things extra complicated we now have a backend-side filter_to_query function as well 😉 And yup, let's get rid of filters in the new year.

posthog/posthog/hogql_queries/legacy_compatibility/filter_to_query.py

Line 323 in fed2153

formula=filter.get("formula"),

[Twixes]

Thanks, updated this too!

[thmsobrmlr]

Expanding on the conversation with @benjackwhite #19323 (comment), should I see this as a +1 to remove the eventUsageLogic?

[Twixes]

Yeah, I agree with Ben. I don't think eventUsageLogic is either helpful nor unhelpful… it's just there as boilerplate, but then I don't see a point in using it. It's rare that we want to capture the same event at two call sites, and for reference purposes searching posthog.capture( is just as easy as opening eventUsageLogic.ts.

[Twixes]

Thanks for taking a look @thmsobrmlr. All conversion and tests should be updated now.
Also I added one small quality of life improvement: "Decimal places" should now only show up in Trends insights that might have fractional values (so e.g. "average property values", but not "total count").

[thmsobrmlr]

Thanks for taking a look @thmsobrmlr. All conversion and tests should be updated now. Also I added one small quality of life improvement: "Decimal places" should now only show up in Trends insights that might have fractional values (so e.g. "average property values", but not "total count").

Makes sense and looks good to me!