Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arbitrary div placeholders #19231

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix: arbitrary div placeholders #19231

merged 4 commits into from
Dec 11, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 10, 2023 •
edited
Loading

Show placeholders using divs in mobile replays... grey background and the placeholder label

Screenshot 2023-12-09 at 21 28 41

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@pauldambra pauldambra changed the title fix: arbitrary svg placeholders fix: arbitrary div placeholders Dec 11, 2023
@pauldambra pauldambra requested a review from a team December 11, 2023 13:02
@pauldambra
Copy link
Member Author

@marandaneto my local environment is fighting me... might push this and test in prod

@pauldambra pauldambra merged commit 9fa663b into master Dec 11, 2023
75 checks passed
@pauldambra pauldambra deleted the fix/arbitrary-placeholders branch December 11, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pauldambra