Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: LemonSelect caret position #19106

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: LemonSelect caret position #19106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/lib/lemon-ui/LemonSelect/LemonSelect.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,8 @@ body:not(.posthog-3000) {
}
}
}

.LemonButton.LemonSelect {
--lemon-button-gap: 0.1875rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 0.25rem so maybe this can be pushed to be even smaller. I'm going to be honest I can't see the difference

}
}
2 changes: 1 addition & 1 deletion frontend/src/lib/lemon-ui/LemonSelect/LemonSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export function LemonSelect<T extends string | number | boolean | null>({
closeParentPopoverOnClickInside={menu?.closeParentPopoverOnClickInside}
>
<LemonButton
className={clsx(className, isClearButtonShown && 'LemonSelect--clearable')}
className={clsx(className, 'LemonSelect', isClearButtonShown && 'LemonSelect--clearable')}
icon={activeLeaf?.icon}
// so that the pop-up isn't shown along with the close button
sideIcon={isClearButtonShown ? <></> : undefined}
Expand Down
Loading