chore: update code syntax highlighting in 3000 #19104
Conversation
|
Size Change: +153 kB (+8%) 🔍 Total Size: 1.99 MB
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
@corywatilo I used the accent color as a background for the code snippet but as in this screenshot it can sometimes appear on top of an accent background. Any color we should use to avoid clashes?
There was a problem hiding this comment.
Can you point me to an example?
There was a problem hiding this comment.
This screenshot shows it, basically this portion:
The code snippet has the same background as the settings panel. https://app.posthog.com/notebooks#panel=settings if you want to see it in action
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Want to add a story with include3000 perhaps? 😃
Code looks good to me, but I'll also let @corywatilo check how this matches the website's style.
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Our code blocks in the app do not match the marketing site
Changes
Sadly the
prism-react-rendererpackage we use on the marketing site does not use the exact same theming systems asreact-syntax-highlighter(we should possibly change that in future). Ported over the custom colors and everything looked decentHow did you test this code?
Visually