Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Matter for BoldNumber #19096

Merged
merged 8 commits into from
Dec 6, 2023
Merged

fix: use Matter for BoldNumber #19096

merged 8 commits into from
Dec 6, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Dec 5, 2023

Problem

We use the font-title variable for headings but the BoldNumber is wrapped in a div

Changes

Set the font family of the BoldNumber__value (e.g. just the title) to be that of the title (default to Matter if available)

How did you test this code?

Need to test in production as fonts do not work locally yet

@daibhin daibhin mentioned this pull request Dec 5, 2023
98 tasks
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Size Change: +237 B (0%)

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.83 MB +237 B (0%)

compressed-size-action

@daibhin daibhin requested a review from a team December 5, 2023 15:47
@corywatilo
Copy link
Contributor

In general I'm trying to restrict Matter to being used only in chrome, not in customer data. I didn't see what this changed, but sounds like it would do that?

@daibhin
Copy link
Contributor Author

daibhin commented Dec 5, 2023

@corywatilo relates to this thread: https://posthog.slack.com/archives/C04L2CV12V9/p1701110786218959. Maybe the right answer is to not use Matter in the pie chart - thoughts?

@corywatilo
Copy link
Contributor

Correct, yeah I'd go with Inter in this case.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit f311af4 into master Dec 6, 2023
78 checks passed
@daibhin daibhin deleted the dn-fix/bold-number-font branch December 6, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants