-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Matter for BoldNumber #19096
Conversation
Size Change: +237 B (0%) Total Size: 1.83 MB ℹ️ View Unchanged
|
In general I'm trying to restrict Matter to being used only in chrome, not in customer data. I didn't see what this changed, but sounds like it would do that? |
@corywatilo relates to this thread: https://posthog.slack.com/archives/C04L2CV12V9/p1701110786218959. Maybe the right answer is to not use Matter in the pie chart - thoughts? |
Correct, yeah I'd go with Inter in this case. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
We use the
font-title
variable for headings but the BoldNumber is wrapped in a divChanges
Set the font family of the
BoldNumber__value
(e.g. just the title) to be that of the title (default to Matter if available)How did you test this code?
Need to test in production as fonts do not work locally yet