fix: button destroy states in 3000 #19086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
tiina303
reviewed
Dec 5, 2023
| @@ -78,7 +80,7 @@ export function AppManagementView({ | |||
| } | |||
| data-attr="plugin-uninstall" | |||
| > | |||
| Uninstall | |||
| Uninstall me | |||
There was a problem hiding this comment.
why the "me", in any case this is the older UI that will be replaced by pipeline folder
There was a problem hiding this comment.
Whoops! That was just me testing to make sure I was looking at the correct button. Removed in the latest commit
|
Size Change: +237 B (0%) Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-fix/button-states
branch
from
283b3a9 to
14bdb74
Compare
thmsobrmlr
requested changes
Dec 5, 2023
frontend/src/scenes/instance/SystemStatus/InstanceConfigSaveModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/settings/organization/OrganizationDangerZone.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Obermüller <[email protected]>
…dal.tsx Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
…ne.tsx Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
Co-authored-by: Thomas Obermüller <[email protected]>
thmsobrmlr
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not support the
type=primary&status=dangercombo in PostHog 3000 (yet... until we decide on the new button system)Changes
type="secondary"only in 3000Needed to change one place we had two danger buttons next to each other because we no longer have a primary & secondary danger button. Decided to use tertiary instead, for now
How did you test this code?
By 👁️