fix: Creating multiple new notebooks leading to an issue #19077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +174 kB (+9%) 🔍 Total Size: 2.01 MB
|
daibhin
approved these changes
Dec 5, 2023
| ], | ||
| }), | ||
| actions({ | ||
| selectNotebook: (id: string, autofocus: EditorFocusPosition | undefined = undefined) => ({ id, autofocus }), | ||
| selectNotebook: (id: string, options: { autofocus?: EditorFocusPosition; silent?: boolean } = {}) => ({ |
There was a problem hiding this comment.
silent as a prop name confused me for a little bit. Wonder if there's something else we could call it or add a description for what it achieves. Maybe open or more explicitly openInSidePanel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We create a new notebook on the scene mounting if the id is "new" but this doesn't work when going back and forth as the scene gets cached by some other app logic I'm not fully up to speed with.
Changes
TODO
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?