feat: Notebook list sorting and filtering #19058
Conversation
| createdByColumn<NotebookListItemType>() as LemonTableColumn< | ||
| NotebookListItemType, | ||
| keyof NotebookListItemType | undefined | ||
| >, | ||
| createdAtColumn<NotebookListItemType>() as LemonTableColumn< | ||
| atColumn<NotebookListItemType>('created_at', 'Created') as LemonTableColumn< |
There was a problem hiding this comment.
Any reason not to use the createdAtColumn helper anymore? Guessing it's to be consistent and avoid another import
There was a problem hiding this comment.
Mostly because I figured eventually we could just ditch it altogether but no strong reason
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -52 B (0%) Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs.png
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
We have notebook listing hardcoded to 100 results and all ordering done in memory.
Changes
TODO
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Mostly with my eyes