Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-server): remove statsd #19027

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

bretthoerner
Copy link
Contributor

@bretthoerner bretthoerner commented Dec 1, 2023

Problem

We've migrated StatsD metrics to Prometheus, so this is dead code.

Changes

Rip out StatsD.

Note that I'm still working on Grafana dashboards, and won't merge this until those are complete.

(This PR currently has a commit that will be separately merged here.)

@bretthoerner bretthoerner force-pushed the brett/remove-ps-statsd branch 3 times, most recently from 46b97bd to 9de1886 Compare December 1, 2023 20:55
@bretthoerner bretthoerner marked this pull request as ready for review December 1, 2023 21:18
@bretthoerner bretthoerner requested a review from a team December 1, 2023 21:22
Copy link
Contributor

@davemurphysf davemurphysf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo; 🪦 RIP StatsD

LGTM

@bretthoerner bretthoerner force-pushed the brett/remove-ps-statsd branch from 9de1886 to a141f39 Compare December 1, 2023 22:00
@bretthoerner bretthoerner force-pushed the brett/remove-ps-statsd branch from a141f39 to ab06ab1 Compare December 5, 2023 16:51
@bretthoerner bretthoerner merged commit 1f6ce77 into master Dec 5, 2023
72 checks passed
@bretthoerner bretthoerner deleted the brett/remove-ps-statsd branch December 5, 2023 18:47
Twixes pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants