feat(commands): add commands for sidebar items #19020
Conversation
| if (tab === SidePanelTab.Activation && (!isReady || hasCompletedAllTasks)) { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm a bit unsure about this change. Essentially I'm moving removing the activation tab from enabledTabs, instead of visibleTabs. Maybe @benjackwhite can say if we'd still need that.
There was a problem hiding this comment.
It was somewhat purposeful as otherwise it just closes all of a sudden. But I think it is also fine if it is hidden I guess. Makes the snapshot a bit pointless though...
|
Size Change: +46 B (0%) Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| if (tab === SidePanelTab.Activation && (!isReady || hasCompletedAllTasks)) { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
It was somewhat purposeful as otherwise it just closes all of a sudden. But I think it is also fine if it is hidden I guess. Makes the snapshot a bit pointless though...
# Conflicts: # frontend/__snapshots__/scenes-app-sidepanels--side-panel-activation.png # frontend/src/lib/components/CommandPalette/commandPaletteLogic.tsx
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
One of the missing pieces here is "Follow up to add opening panels as command".
Changes
This PR adds said functionality.
How did you test this code?
⌨️