fix(3000): Improve opacity of profile pictures #19004
Conversation
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated35 snapshot changes in total. 0 added, 35 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated30 snapshot changes in total. 0 added, 30 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
There's a lot of button changes that need to be merged in this PR: #18949. Worried we'll have unnecessary merge conflicts if we make these changes on the old style buttons. I'm happy to work these changes into the new PR or hold off until after it has merged and do them as a follow up |
📸 UI snapshots have been updated9 snapshot changes in total. 0 added, 9 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated9 snapshot changes in total. 0 added, 9 modified, 0 deleted:
Triggered by this commit. |
|
Re-requesting your review @daibhin since I want to be sure I did styles correctly in the new buttons! |
| padding: 0; | ||
| margin-left: 0.25rem; | ||
| } | ||
| } | ||
|
|
||
| .LemonButton--small .LemonButtonWithSideAction__spacer--divider { | ||
| height: 1.125rem; |
There was a problem hiding this comment.
Maybe beyond the scope of this PR but feels like this value could drift from https://github.com/PostHog/posthog/pull/19004/files#diff-c694fbbe6b6ff7273c964743f37751e5416009c150d0a9ddad1b4c031ef006d3R264. Perhaps the height should be a calc based on the button height minus some vertical padding
There was a problem hiding this comment.
This actually shouldn't be needed with the recent refactoring, so removed!
| @@ -300,6 +313,11 @@ | |||
| } | |||
| } | |||
|
|
|||
| .LemonButton__icon { | |||
| color: currentColor; | |||
| opacity: 0.5; | |||
There was a problem hiding this comment.
Does --lemon-button-icon-opacity: 0.5 work here?
There was a problem hiding this comment.
Yup! Thanks, changed to that
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Twixes
force-pushed
the
improve-3000-profile-picture-opacity
branch
from
549a5ac to
fcec097
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Twixes
force-pushed
the
improve-3000-profile-picture-opacity
branch
from
e88daca to
cb2a332
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Hmm thought I fixed this in #19045
There was a problem hiding this comment.
I've seen this flapping on a bunch of PRs now
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
This looked wrong:
Changes
This looks right:
(Though, because of the background being transparent if there's a gravatar, there is now a flash of purple on app load.)