feat: Use single entrypoint for both images but detect which to run #18883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
changed the title
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
frankh
force-pushed
the
frank/docker-entrypoint-backwards-compatible
branch
3 times, most recently
from
39982dc to
adf4172
Compare
We want it to be a full drop-in replacement
frankh
force-pushed
the
frank/docker-entrypoint-backwards-compatible
branch
from
b9370d4 to
c7e16dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's more difficult that anticipated to switch the entrypoint for different images, make the new image a drop-in replacement
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?