feat(web-analytics): Choose sensible interval for graphs #18860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
changed the title
mariusandra
reviewed
Nov 23, 2023
robbie-c
force-pushed
the
choose-sensible-interval-for-graphs
branch
from
a779d4c to
3fc1a08
Compare
|
Size Change: +377 B (0%) Total Size: 1.83 MB
|
robbie-c
commented
Nov 30, 2023
| @@ -729,7 +749,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([ | |||
| const geoIpPluginConfig = | |||
| isNotNil(geoIpPluginId) && | |||
| pluginsConfigResponse.status === 'fulfilled' && | |||
| pluginsConfigResponse.value.find((plugin) => plugin.id === geoIpPluginId) | |||
| pluginsConfigResponse.value.find((plugin) => plugin.plugin === geoIpPluginId) | |||
mariusandra
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Nice! Here's a ✅ , though it might be worth adding (or letting chatgpt add) a few more tests to utils.test.ts? You added a few new functions, but tests only for getDefaultInterval. Or you think e.g. testing dateStringToComponents via dateStringToDayJs is good enough? I don't feel too strongly here, so happy to merge without.
robbie-c
force-pushed
the
choose-sensible-interval-for-graphs
branch
from
cb662e3 to
0f1728c
Compare
robbie-c
force-pushed
the
choose-sensible-interval-for-graphs
branch
from
6d4b806 to
6d652e6
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently if you choose the last 24 hours, you see a daily view, which is not helpful as there is 1 data point.
Additionally if you choose past year, you also get a daily view, which again not helpful as you have hundreds of data points.
Changes
Try to choose a sensible interval based on the date range. For the default options in the date picker, these are already set, but provide a fallback.
Do something similar when changing the interval, if the existing date range is not compatible with the new interval then change the date range.
Note: I could have gone further into this, particularly handling custom date ranges. This is something I'll follow up with in a separate PR when I let people change the interval
Used the dates in trends when comparing to previous periods
How did you test this code?
Some unit tests