-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Debounce the resize observer to help with window resizing #18853
Conversation
Size Change: +147 B (0%) Total Size: 1.83 MB ℹ️ View Unchanged
|
This feel better than I thought it would! |
Yeah, the slight delay in some things correctly rendering is made up for immediately by things actually reacting to the viewport changes 😅 |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Looks like funnel bars don't want to stop resizing in Storybook after this @benjackwhite 🤔 |
Yeah its why this is going stale because I can't figure it out... |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
We currently fire a lot of re-rendering on resizing which can make things feel really sluggish. Most of the time we don't need this to be "real time" so we can have a slight delay
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?