Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(3000): Welcome panel #18842
feat(3000): Welcome panel #18842
Changes from all commits
01ddcca
ac8c586
a28b9e4
b5c7468
635ed63
0544d51
214c782
2f91d4b
592fe45
07d3406
525d9bc
fdae1b1
447bd70
38cecad
0497658
f12d7c9
bc90f35
499c7d1
dca580d
48e88b8
054508d
73c4261
04a7c36
a77bf08
8ae149c
e819032
869e3b7
4510766
349332b
a63379b
48473de
2ddc406
5e825d8
8ced783
d06f6c3
0f0b342
2c80063
bcc56ae
1dfb49a
f0c132d
11b96d9
e76fbd7
adb0f02
f28cfc5
8afcc3e
727e6c7
2b9e093
afaf955
e2a822e
40bff04
4178540
aab7a63
507fa90
90b949d
f45e252
32e4b94
4026322
3acfd17
06d5e94
6f72d70
8923a3a
6e413b7
bd7b40c
a9b9675
645d68e
becee00
f953d15
92a284f
f042e21
0d62428
e9bdf41
1fce892
289f04a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 36 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 68 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most style guides have a rule for spelling the numbers out when they're under ten (sometimes even under a hundred), because "zero to one" is much more legible than "0 to 1" in a non-technical context. I think the startup-y reference is also clearer with "zero to one" rather than "0 to 1", because the former is what the book is called.
This is a bit tricky because then we're introducing 3000, which is a large number. I added an ellipsis to make the context shift explicit, maybe that helps?
Check warning on line 122 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 123 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 139 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 140 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 152 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 169 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 170 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
Check warning on line 191 in frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
GitHub Actions / Code quality checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "command palette" is the old name… the new iteration is called the "command bar"