Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show label on data with one value #18826

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: Show label on data with one value #18826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions frontend/src/scenes/insights/views/LineGraph/PieChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,8 @@ export function PieChart({
},
display: (context) => {
const percentage = getPercentageForDataPoint(context)
return (showValueOnSeries !== false || // show if true or unset
showLabelOnSeries) &&
context.dataset.data.length > 1 &&
percentage > 5
? 'auto'
: false
const showValueForSeries = showValueOnSeries !== false && context.dataset.data.length > 1 // show if true or unset
return (showValueForSeries || showLabelOnSeries) && percentage > 5 ? 'auto' : false
},
padding: (context) => {
// in order to make numbers below 10 look circular we need a little padding
Expand Down
Loading