Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Refactor temporal env var #18824

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 22, 2023

Problem

  • folders and env vars are coded to batch_exports specifically

Changes

  • refactor folder so that it's extendable
  • update github action to have batch export in description and worker name sent to helm deployment config

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@EDsCODE EDsCODE marked this pull request as ready for review November 22, 2023 19:34
@posthog-bot
Copy link
Contributor

Hey @EDsCODE! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@EDsCODE EDsCODE requested a review from tomasfarias November 27, 2023 18:27
Copy link
Contributor

@tomasfarias tomasfarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get tests passing, but overall happy with the refactor 👍 Great work!

@EDsCODE EDsCODE merged commit daac935 into master Nov 29, 2023
71 checks passed
@EDsCODE EDsCODE deleted the dw-refactor-temporal-env-var branch November 29, 2023 14:32
Copy link

sentry-io bot commented Nov 29, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: Task queue data-warehouse-task-queue not found in WORKFLOWS_DICT or ACTIVITIES_DICT posthog.management.commands.start_temporal_work... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants