Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notebook preview #18813

Merged
merged 9 commits into from
Nov 27, 2023
Merged

feat: add notebook preview #18813

merged 9 commits into from
Nov 27, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 22, 2023

Problem

Would be nicer if notebooks were previewable from the command bar search

Changes

Render the content inside the Notebook component

How did you test this code?

Screenshot 2023-11-22 at 11 06 26

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@thmsobrmlr thmsobrmlr self-requested a review November 22, 2023 11:38
thmsobrmlr
thmsobrmlr approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@daibhin daibhin merged commit 73baef1 into master Nov 27, 2023
77 checks passed
@daibhin daibhin deleted the dn-feat/notebook-search-preview branch November 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @thmsobrmlr