-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): Expression Fields & PoEv2 #18811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o hogql-hidden-aliases
…column-expressions
mariusandra
changed the title
feat(hogql): column expressions
feat(hogql): column expressions & PoEv2
Nov 23, 2023
mariusandra
changed the title
feat(hogql): column expressions & PoEv2
feat(hogql): Expression Fields & PoEv2
Nov 23, 2023
Gilbert09
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #18725
Problem
We need support for custom SQL expressions in HogQL tables.
person_id
on events with PoEv2 has to evaluate to something likeoverride.override_person_id or events.person_id
Changes
person.id
when PoEv2 is enabled, makes it use theoverride vs old_id
code.Known limitation
The current expression fields have no concept of
this
. Withevents.a = event
, when runningselect distinct_id as event, a from events
, we'd return thedistinct_id
twice, instead ofa
resolving to theevent
field, which was the only one in scope when the expression field was defined.This will be fixed in a followup, but is non-blocking today. The biggest problem this can cause is a "error redefining alias" message or an otherwise erroring query, such as not knowing which person_id to choose if there are many in scope.
Effectively this means we can play around with these custom fields, but we shouldn't release a "calculated properties" feature to users today.
How did you test this code?
Wrote tests. Tested the new lifecycle query with PoEv2 enabled, everything just worked on the first go. It was magical.