Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 3000 snapshots #18792

Merged
merged 22 commits into from
Nov 23, 2023
Merged

chore: 3000 snapshots #18792

merged 22 commits into from
Nov 23, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 21, 2023

Problem

Add 3000 variations of button screenshots

Changes

  • Add include3000 test option
  • Take light and dark mode screenshots in 3000
  • Do not render transparent backgrounds in 3000 mode

How did you test this code?

With tests...inception

@daibhin daibhin changed the title Dn/interactions test chore: 3000 snapshots Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

11 snapshot changes in total. 0 added, 11 modified, 0 deleted:

  • chromium: 0 added, 11 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

38 snapshot changes in total. 0 added, 38 modified, 0 deleted:

  • chromium: 0 added, 38 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin marked this pull request as ready for review November 23, 2023 16:47
@daibhin daibhin requested a review from a team November 23, 2023 17:05
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice!

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Twixes Twixes merged commit e12454a into master Nov 23, 2023
78 checks passed
@Twixes Twixes deleted the dn/interactions-test branch November 23, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants