Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nuke plugin-contrib #18757

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: nuke plugin-contrib #18757

merged 1 commit into from
Dec 5, 2023

Conversation

tiina303
Copy link
Contributor

@tiina303 tiina303 commented Nov 20, 2023

Problem

We've updated all the apps that use plugin-contrib i.e. the old createBuffer strategy

User communication please see: posthog.slack.com/archives/C01FHN8DNN6/p1700503323428169

verified no usage in US nor EU: select * from posthog_pluginsourcefile where source like '%plugin-contrib%'

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

Size Change: 0 B

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.99 MB

compressed-size-action

@tiina303 tiina303 requested a review from a team November 20, 2023 18:04
Copy link
Contributor

@davemurphysf davemurphysf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦
LGTM

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@tiina303 tiina303 force-pushed the nuke-plugin-contrib branch from 8d5ba86 to b43ff9b Compare December 5, 2023 12:48
@tiina303 tiina303 merged commit fc0bd60 into master Dec 5, 2023
71 of 72 checks passed
@tiina303 tiina303 deleted the nuke-plugin-contrib branch December 5, 2023 13:02
Twixes pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants