Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(queries): Set ClickHouse max execution time higher for async queries #18747

Merged
merged 3 commits into from
Nov 21, 2023
Merged

feat(queries): Set ClickHouse max execution time higher for async queries #18747

merged 3 commits into from
Nov 21, 2023

Conversation

webjunkie
Copy link
Contributor

@webjunkie webjunkie commented Nov 20, 2023 •
edited
Loading

Problem

We have #18571 now, but we want a higher timeout since otherwise the queries run just as short in Celery.

Changes

  • use in_export_context=True from async queries and then set a timeout at an appropriate point

How did you test this code?

  • tested from frontend
  • adjusted unit tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Size Change: -12.6 kB (-1%)

Total Size: 2 MB

Filename Size Change
frontend/dist/toolbar.js 2 MB -12.6 kB (-1%)

compressed-size-action

@webjunkie webjunkie marked this pull request as ready for review November 20, 2023 13:33
mariusandra
mariusandra reviewed Nov 20, 2023
View reviewed changes
posthog/hogql/query.py Outdated Show resolved Hide resolved
mariusandra
mariusandra approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mariusandra mariusandra merged commit 63640ff into master Nov 21, 2023
67 checks passed
@mariusandra mariusandra deleted the feature/query-slow-lane-timeout branch November 21, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webjunkie @mariusandra