fix: Some issues with onboarding for 3000 #18746

benjackwhite · 2023-11-20T11:46:44Z

Problem

Some remaining work to be done

Changes

Fixes the flex layout for the product cards
Fixes a bunch of button sizes and issues
Fixes the input selected to just use the border color

TODO

Fix the topbar not being shown for 3000
Confirm signup/login buttons look correct

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

github-actions · 2023-11-20T11:54:11Z

Size Change: -27 B (0%)

Total Size: 2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2 MB	-27 B (0%)

_{compressed-size-action}

posthog-bot · 2023-11-20T12:13:57Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-20T12:22:38Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-20T12:31:46Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-20T12:40:37Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown-edit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown.png

posthog-bot · 2023-11-20T14:22:18Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-20T15:29:46Z

📸 UI snapshots have been updated

7 snapshot changes in total. 0 added, 7 modified, 0 deleted:

chromium: 0 added, 7 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-20T16:12:05Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

… fix/onboarding-3000

posthog-bot · 2023-11-20T16:20:19Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

frontend/src/lib/components/SocialLoginButton/SocialLoginButton.tsx

daibhin · 2023-11-20T18:24:04Z

frontend/src/lib/lemon-ui/LemonInput/LemonInput.scss

    }

    &.LemonInput--focused:not([aria-disabled='true']) {
        border-color: var(--primary-3000);
+
+        .posthog-3000 & {
+            border-color: var(--border-bold);


I assume this changes everywhere in 3000? Feels like a big change but understand the concerns about it looking like an error state. Just wondering if grey is the greatest active state

I think it is miles better than orange (i.e. nearly red). So yeah I would vote for it as the default until we have a better option

raquelmsmith · 2023-11-20T20:54:47Z

Poked at this a bit. I have code for the following changes to the top nav but will wait until I get the go/no-go from y'all before I push to this branch:

Only show project switcher if the org has multiple projects
Make the user button tertiary
Make both buttons muted so the icon isn't red (not sure where we are on this from a 3000-colors perspective, but it felt really abrupt here)
Added a border below the minimal nav. I'm kinda iffy on this because generally our top "nav" in 3000 (i think mostly breadcrumbs) doesn't have a border, but it looked kind of naked without, and since in this view this is the "primary" nav, I think the border is okay.
Made the posthog logo/icon a bit larger

Only one project:

Multiple projects:

posthog-bot · 2023-11-21T08:43:09Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (wasn't pushed!)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite · 2023-11-21T19:08:22Z

@raquelmsmith I put in the changes as in your screenshots 👍

raquelmsmith · 2023-11-21T19:14:22Z

awesome thanks so much!

raquelmsmith · 2023-11-21T21:30:37Z

Whoops, I think this broke onboarding - bridge pages are no longer scrollable. My fault really since I have no tests for onboarding flows.... I'm going to revert this since it's not super critical and then we can fix

raised by user in #18799

This reverts commit 0e15477.

Fixed layout

f037147

benjackwhite and others added 3 commits November 20, 2023 13:04

Merge branch 'master' into fix/onboarding-3000

03ce9ef

Update UI snapshots for chromium (1)

44a478b

Update UI snapshots for chromium (2)

6e3c23f

github-actions bot added 2 commits November 20, 2023 12:22

Update UI snapshots for chromium (2)

7ddf27f

Update UI snapshots for chromium (1)

7977d07

Update UI snapshots for chromium (2)

f35e052

Update UI snapshots for chromium (2)

15f95a5

benjackwhite and others added 2 commits November 20, 2023 15:13

Merge branch 'master' into fix/onboarding-3000

d106b3e

# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown-edit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown.png

Update UI snapshots for chromium (2)

0a0ad24

benjackwhite and others added 3 commits November 20, 2023 16:20

Fixed up styles

221c520

Update UI snapshots for chromium (1)

346cb84

Update UI snapshots for chromium (2)

17ed341

benjackwhite and others added 2 commits November 20, 2023 17:03

Fixes

0653bc3

Update UI snapshots for chromium (1)

8a8ce5e

benjackwhite and others added 4 commits November 20, 2023 17:15

Fixed up views

28ab4fb

Update UI snapshots for chromium (1)

1c4e3ee

Fix

66072dc

Merge branch 'fix/onboarding-3000' of github.com:PostHog/posthog into…

862c722

… fix/onboarding-3000

benjackwhite marked this pull request as ready for review November 20, 2023 16:21

benjackwhite requested a review from raquelmsmith November 20, 2023 16:21

benjackwhite requested a review from a team November 20, 2023 16:21

daibhin approved these changes Nov 20, 2023

View reviewed changes

Twixes force-pushed the fix/onboarding-3000 branch from 13d110a to 862c722 Compare November 20, 2023 20:13

benjackwhite added 2 commits November 21, 2023 09:26

Fixed up styles

aa52116

Fix

6b3a2e9

benjackwhite enabled auto-merge (squash) November 21, 2023 08:28

benjackwhite merged commit 0e15477 into master Nov 21, 2023
71 of 72 checks passed

benjackwhite deleted the fix/onboarding-3000 branch November 21, 2023 08:40

raquelmsmith added a commit that referenced this pull request Nov 21, 2023

Revert "fix: Some issues with onboarding for 3000 (#18746)"

67b7e10

This reverts commit 0e15477.

raquelmsmith mentioned this pull request Nov 21, 2023

revert: fix: Some issues with onboarding for 3000 #18800

Closed

xrdt mentioned this pull request Nov 22, 2023

Sprint November 27 - December 8 #18807

Closed

daibhin mentioned this pull request Nov 27, 2023

feat(3000): style antd number inputs according to 3000 #18882

Merged

raquelmsmith mentioned this pull request Dec 6, 2023

Sprint December 11 - December 22 #19116

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Some issues with onboarding for 3000 #18746

fix: Some issues with onboarding for 3000 #18746

benjackwhite commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

posthog-bot commented Nov 20, 2023

daibhin Nov 20, 2023

benjackwhite Nov 20, 2023

raquelmsmith commented Nov 20, 2023 •

edited

Loading

posthog-bot commented Nov 21, 2023

benjackwhite commented Nov 21, 2023

raquelmsmith commented Nov 21, 2023

raquelmsmith commented Nov 21, 2023 •

edited

Loading

fix: Some issues with onboarding for 3000 #18746

fix: Some issues with onboarding for 3000 #18746

Conversation

benjackwhite commented Nov 20, 2023 • edited Loading

Problem

Changes

TODO

How did you test this code?

github-actions bot commented Nov 20, 2023 • edited Loading

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 20, 2023

📸 UI snapshots have been updated

daibhin Nov 20, 2023

Choose a reason for hiding this comment

benjackwhite Nov 20, 2023

Choose a reason for hiding this comment

raquelmsmith commented Nov 20, 2023 • edited Loading

posthog-bot commented Nov 21, 2023

📸 UI snapshots have been updated

benjackwhite commented Nov 21, 2023

raquelmsmith commented Nov 21, 2023

raquelmsmith commented Nov 21, 2023 • edited Loading

benjackwhite commented Nov 20, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

raquelmsmith commented Nov 20, 2023 •

edited

Loading

raquelmsmith commented Nov 21, 2023 •

edited

Loading