Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): unexpected survey response type breaks results page #18731

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Nov 17, 2023

Problem

In the open text viz, react throws a child object error when the response is in an object form. We should at least handle it

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@liyiy liyiy requested a review from jurajmajerik November 17, 2023 20:04
@liyiy liyiy changed the title fix(surveys): unexpected survey responses break the page fix(surveys): unexpected survey response type breaks results page Nov 17, 2023
@liyiy liyiy enabled auto-merge (squash) November 17, 2023 20:05
Copy link
Contributor

github-actions bot commented Nov 17, 2023

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@liyiy liyiy merged commit 4164eee into master Nov 17, 2023
74 checks passed
@liyiy liyiy deleted the stringify-survey-responses-viz branch November 17, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants