Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use system.parts table to get count of rows. much cheaper #18730

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

fuziontech
Copy link
Member

Problem

We are currently doing a huge scan of rows to get counts from clickhouse stats. We really should just query the metadata store for this as it's faster and cheaper...
and less likely to blow out the cache.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@fuziontech fuziontech requested a review from tkaemming November 17, 2023 22:26
@fuziontech fuziontech enabled auto-merge (squash) November 18, 2023 23:23
@fuziontech fuziontech merged commit dd5be88 into master Nov 18, 2023
64 checks passed
@fuziontech fuziontech deleted the use_parts branch November 18, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants