Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't throw on inserts into too many parts on dev #18727

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore: don't throw on inserts into too many parts on dev #18727

merged 1 commit into from
Nov 17, 2023

Conversation

fuziontech
Copy link
Member

@fuziontech fuziontech commented Nov 17, 2023 •
edited
Loading

Problem

Problem right now is that on dev or in tests you can insert into too many partitions for log_entries which is acceptable when not in production. Instead of having clickhouse throw on this we have it warn and keep going.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @fuziontech! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@fuziontech fuziontech requested a review from tkaemming November 17, 2023 19:24
@fuziontech fuziontech merged commit 46e8f1b into master Nov 17, 2023
69 checks passed
@fuziontech fuziontech deleted the partitions branch November 17, 2023 19:24
fuziontech added a commit that referenced this pull request Nov 17, 2023
@fuziontech
Revert "chore: don't throw on inserts into too many parts on dev (#18727
ca03200 
)"

This reverts commit 46e8f1b.
@fuziontech fuziontech mentioned this pull request Nov 17, 2023
Merged
fuziontech added a commit that referenced this pull request Nov 17, 2023
@fuziontech
Revert "chore: don't throw on inserts into too many parts on dev" (#1…
b5b492f 
…8728)

Revert "chore: don't throw on inserts into too many parts on dev (#18727)"

This reverts commit 46e8f1b.
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaemming tkaemming Awaiting requested review from tkaemming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuziontech @posthog-bot