Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default color icon 3000 #18721

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 17, 2023

Problem

Button icons had the wrong color in dark mode

Screenshot 2023-11-17 at 16 46 26

Changes

Move the icon styling to legacy

How did you test this code?

Screenshot 2023-11-17 at 16 50 52

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Size Change: 0 B

Total Size: 2.01 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.01 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

26 snapshot changes in total. 0 added, 26 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin requested a review from a team November 17, 2023 18:41
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke primary buttons

@daibhin daibhin force-pushed the dn-fix/use-default-color-icon-3000 branch from 714670b to 85fe74d Compare November 20, 2023 16:04
@daibhin daibhin requested review from benjackwhite and a team November 20, 2023 17:03
@daibhin daibhin merged commit 217b365 into master Nov 21, 2023
73 checks passed
@daibhin daibhin deleted the dn-fix/use-default-color-icon-3000 branch November 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants