feat(onboarding): add product config screen #18720

raquelmsmith · 2023-11-17T16:51:20Z

Problem

Some products need to have a config - eg. product analytics + autocapture, and soon session replay + minimum duration or sampling controls. We need a screen in onboarding to set this.

Changes

Adds a new onboarding screen where these configs can live.

Note: I think I'm just going to go ahead and extend this for session replay now and put it behind a flag.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Having issues with running storybook locally so no tests for now...

github-actions · 2023-11-17T16:58:56Z

Size Change: +59 B (0%)

Total Size: 1.83 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.83 MB	+59 B (0%)

_{compressed-size-action}

xrdt · 2023-11-21T23:31:48Z

frontend/src/scenes/onboarding/OnboardingProductConfiguration.tsx

+    }, [])
+
+    return configOptions ? (
+        <OnboardingStep title={`Set up your configuration`} stepKey={stepKey} continueAction={saveConfiguration}>


Maybe a bit more clear to say "Configure ${product.name}"?

posthog-bot · 2023-11-29T07:31:00Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

pauldambra · 2023-11-30T10:26:57Z

frontend/src/scenes/onboarding/Onboarding.tsx

+                        inverseToggle: true,
+                    },
+                ]}
+            />
        </OnboardingWrapper>
    )


Ha, github won't let me comment on the replay lines because they've not changed 🙈

Would be cool to have the basic settings here

Ultimately we'll want the cost controls here too

Yep! Planning on picking this up again today 👍

raquelmsmith · 2023-12-01T19:35:56Z

@pauldambra this is what we've got now for session replay onboarding config:

Note: When someone starts onboarding to session replay, the toggle to record sessions is automatically enabled, so it's not shown as an option here.

Note 2: I don't love the design here but @corywatilo tells me he's going to redesign all this once 3000 is out so I'm fine with this for now 😛

LMK your thoughts + code review is helpful + we can merge next week.

posthog-bot · 2023-12-01T19:43:50Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (wasn't pushed!)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

pauldambra

LGTM

frontend/src/scenes/onboarding/Onboarding.tsx

Co-authored-by: Paul D'Ambra <[email protected]>

posthog-bot · 2023-12-05T17:19:12Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…b.com/PostHog/posthog into feat/onboarding-product-config-screen

posthog-bot · 2023-12-05T17:44:14Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-05T17:53:04Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-05T18:02:54Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-12-05T18:12:22Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* stub out config screen * saave the configuration * fix * add existing replay controls to config * dont show any toasts in onboarding * add minimum duration option * move dropdown * flag the control * Update frontend/src/scenes/onboarding/Onboarding.tsx Co-authored-by: Paul D'Ambra <[email protected]> --------- Co-authored-by: Paul D'Ambra <[email protected]>

raquelmsmith added 3 commits November 17, 2023 07:41

stub out config screen

f203a46

saave the configuration

8600f48

fix

090ba08

raquelmsmith requested review from pauldambra and xrdt November 17, 2023 16:51

xrdt approved these changes Nov 21, 2023

View reviewed changes

posthog-bot added the stale label Nov 29, 2023

pauldambra reviewed Nov 30, 2023

View reviewed changes

raquelmsmith removed the stale label Nov 30, 2023

raquelmsmith added 6 commits November 30, 2023 11:36

Merge branch 'master' into feat/onboarding-product-config-screen

d619a6b

add existing replay controls to config

3571c68

dont show any toasts in onboarding

e04fc64

add minimum duration option

565213d

move dropdown

bf2906d

flag the control

4c1e931

Merge branch 'master' into feat/onboarding-product-config-screen

a20f212

Merge branch 'master' into feat/onboarding-product-config-screen

25dd07f

raquelmsmith mentioned this pull request Dec 4, 2023

Sprint November 27 - December 8 #18807

Closed

raquelmsmith requested a review from pauldambra December 4, 2023 22:20

pauldambra approved these changes Dec 5, 2023

View reviewed changes

frontend/src/scenes/onboarding/Onboarding.tsx Outdated Show resolved Hide resolved

Update frontend/src/scenes/onboarding/Onboarding.tsx

ec4649b

Co-authored-by: Paul D'Ambra <[email protected]>

raquelmsmith enabled auto-merge (squash) December 5, 2023 17:10

Update UI snapshots for chromium (1)

be01f8c

raquelmsmith added 2 commits December 5, 2023 09:32

Merge branch 'feat/onboarding-product-config-screen' of https://githu…

b54ff44

…b.com/PostHog/posthog into feat/onboarding-product-config-screen

Merge branch 'master' into feat/onboarding-product-config-screen

d18c625

Update UI snapshots for chromium (1)

8f22d3c

Update UI snapshots for chromium (1)

bc63fe8

github-actions bot added 2 commits December 5, 2023 18:01

Update UI snapshots for chromium (1)

1174790

Update UI snapshots for chromium (2)

b763148

github-actions bot added 2 commits December 5, 2023 18:11

Update UI snapshots for chromium (1)

29ce3e8

Update UI snapshots for chromium (2)

cd62dfe

raquelmsmith merged commit 14d3db3 into master Dec 5, 2023
78 checks passed

raquelmsmith deleted the feat/onboarding-product-config-screen branch December 5, 2023 20:32

raquelmsmith mentioned this pull request Dec 6, 2023

Sprint December 11 - December 22 #19116

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(onboarding): add product config screen #18720

feat(onboarding): add product config screen #18720

raquelmsmith commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

xrdt Nov 21, 2023

posthog-bot commented Nov 29, 2023

pauldambra Nov 30, 2023

raquelmsmith Nov 30, 2023

raquelmsmith commented Dec 1, 2023 •

edited

Loading

posthog-bot commented Dec 1, 2023

pauldambra left a comment

posthog-bot commented Dec 5, 2023

posthog-bot commented Dec 5, 2023

posthog-bot commented Dec 5, 2023

posthog-bot commented Dec 5, 2023

posthog-bot commented Dec 5, 2023

feat(onboarding): add product config screen #18720

feat(onboarding): add product config screen #18720

Conversation

raquelmsmith commented Nov 17, 2023 • edited Loading

Problem

Changes

How did you test this code?

github-actions bot commented Nov 17, 2023 • edited Loading

xrdt Nov 21, 2023

Choose a reason for hiding this comment

posthog-bot commented Nov 29, 2023

pauldambra Nov 30, 2023

Choose a reason for hiding this comment

raquelmsmith Nov 30, 2023

Choose a reason for hiding this comment

raquelmsmith commented Dec 1, 2023 • edited Loading

posthog-bot commented Dec 1, 2023

📸 UI snapshots have been updated

pauldambra left a comment

Choose a reason for hiding this comment

posthog-bot commented Dec 5, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 5, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 5, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 5, 2023

📸 UI snapshots have been updated

posthog-bot commented Dec 5, 2023

📸 UI snapshots have been updated

raquelmsmith commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

raquelmsmith commented Dec 1, 2023 •

edited

Loading