feat(3000): Allow renaming the current item from the top bar #18709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
3000-top-bar-edit-name
branch
from
2dfd908 to
82aec14
Compare
Twixes
force-pushed
the
3000-top-bar-edit-name
branch
from
681e49f to
6bbaf5a
Compare
|
Size Change: +565 B (0%) Total Size: 2.01 MB
|
Twixes
force-pushed
the
3000-top-bar-edit-name
branch
from
b79b180 to
f9a0945
Compare
📸 UI snapshots have been updated114 snapshot changes in total. 0 added, 114 modified, 0 deleted:
Triggered by this commit. |
It was using a class only defined in `Insight.scss`, so the class didn't actually work in dashboards.
Twixes
force-pushed
the
3000-top-bar-edit-name
branch
from
fe6cf41 to
b6de023
Compare
📸 UI snapshots have been updated113 snapshot changes in total. 0 added, 113 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the 3000 UI page headers are exclusively in the top bar now. One thing that wasn't carried over was item renaming though.
Changes
You can now remain the currently viewed item intuitively:
Currently implemented for insights, dashboards, and notebook, as this PR focuses on the system.
It can be useful to review each sequentially, as each builds on top of the previous one.