-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-warehouse): DLT + temporal #18700
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
@@ -300,3 +300,5 @@ class FlagRequestType(str, Enum): | |||
|
|||
|
|||
ENRICHED_DASHBOARD_INSIGHT_IDENTIFIER = "Feature Viewed" | |||
DATA_WAREHOUSE_TASK_QUEUE = "data-warehouse-task-queue" | |||
BATCH_EXPORTS_TASK_QUEUE = "no-sandbox-python-django" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mental note: I should change the batch exports queue name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new mental note: Doing this would require being really careful, so maybe I'll get over the fact we have a bad name for this queue 💀
Yeah, this will be fine. The migration check is using packages from master to validate but this PR introduces a package update that the latest migration relies on |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?