Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect configured LOG_LEVEL during plugin-server setup #18699

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Respect configured LOG_LEVEL during plugin-server setup #18699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5356bf
Use configured log level for pino (status) logger.
tkaemming Nov 16, 2023
0e0a458
Remove seemingly unused override attribute.
tkaemming Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin-server/src/utils/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pino from 'pino'

import { defaultConfig } from '../config/config'
import { LogLevel, PluginsServerConfig } from '../types'
import { isProdEnv } from './env-utils'

Expand All @@ -14,15 +15,14 @@ export interface StatusBlueprint {

export class Status implements StatusBlueprint {
mode?: string
explicitLogLevel?: LogLevel
logger: pino.Logger
prompt: string
transport: any

constructor(mode?: string) {
this.mode = mode

const logLevel: LogLevel = this.explicitLogLevel || LogLevel.Info
const logLevel: LogLevel = defaultConfig.LOG_LEVEL
if (isProdEnv()) {
this.logger = pino({
// By default pino will log the level number. So we can easily unify
Expand Down
Loading