fix(cohorts): Alerting functionality when user enters wrong details while creating cohort #18689
Conversation
| @@ -205,6 +206,7 @@ export const cohortEditLogic = kea<cohortEditLogicType>([ | |||
| }, | |||
| }), | |||
| submit: (cohort) => { | |||
| actions.submitCohort() | |||
There was a problem hiding this comment.
this action exists by default thanks to forms, you shouldn't need to add it yourself, was this not working if you remove the action and this line?
[you can check the generated cohortEditLogicType.ts file for all existing actions
There was a problem hiding this comment.
Yeah, will check the functionality after removing this line. Will update the PR accordingly if it works
There was a problem hiding this comment.
this and the line in actions for the same 👍
There was a problem hiding this comment.
@neilkakkar, I have made the required changes. Can you please take a look!
neilkakkar
changed the title
|
@neilkakkar, #18614 is very similar to the issue here. Can we solve it in a similar way? |
|
indeed! However, we also want to expand the right section in surveys, since it can be pretty hard otherwise to figure out where the error is |
Closes - #18620
At present, When a user clicks on save cohort button without properly filling details, the site feels stuck. The user has to scroll down to the highlighted error box to rectify the details.
Such a situation can be avoided by a simple toast alerting the user that the details filled out in the form has errors.
Screen.Recording.2023-11-16.at.10.35.04.PM.mov
Testing -