Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove exportEvents #18682

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: Remove exportEvents #18682

merged 1 commit into from
Dec 5, 2023

Conversation

tiina303
Copy link
Contributor

@tiina303 tiina303 commented Nov 16, 2023

Problem

All export events apps have been either moved to batch exports or onEvent apps, this means we can remove the related code.

User communication please see: https://posthog.slack.com/archives/C01FHN8DNN6/p1700503323428169

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

verified no usage in clouds select * from posthog_pluginsourcefile where source like '%exportEvents%'

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Size Change: 0 B

Total Size: 1.99 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.99 MB

compressed-size-action

@tiina303 tiina303 force-pushed the nuke-export-events branch 2 times, most recently from da29ebf to c69e91f Compare November 20, 2023 17:41
@tiina303 tiina303 marked this pull request as ready for review November 20, 2023 18:04
@tiina303 tiina303 requested a review from a team November 20, 2023 18:04
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tiina303 tiina303 merged commit e391387 into master Dec 5, 2023
74 checks passed
@tiina303 tiina303 deleted the nuke-export-events branch December 5, 2023 13:40
Twixes pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants